docs: align all .NET version references to .NET 10#245
Merged
Conversation
The repo targets net10.0 across every csproj and CI uses dotnet-version 10.0.x, but several setup docs, design specs, and one bench script still referenced net8/net9. Updating these so contributors aren't pointed at the wrong SDK or sample TFM. Also bumped the AOT-compat gate in Directory.Build.targets from net8.0 to net10.0 (semantically identical for current projects; clarifies the actual baseline). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR aligns repository documentation and helper scripts with the repo’s actual .NET target by updating remaining .NET 8/.NET 9 references to .NET 10, and adjusts the repo-wide AOT-compatibility gating condition accordingly.
Changes:
- Update setup/docs/spec references to use .NET 10 and
net10.0-windows10.0.22621.0. - Update perf/diag PowerShell script to use the net10 TFM output folder.
- Update
Directory.Build.targetsAOT compatibility conditions fromnet8.0→net10.0.
Show a summary per file
| File | Description |
|---|---|
AGENTS.md |
Updates CI and AOT compatibility version references to .NET 10. |
CONTRIBUTING.md |
Updates prerequisites to .NET 10 SDK. |
Directory.Build.targets |
Changes the TFM compatibility baseline for AOT/trimming-related properties to net10.0. |
README.md |
Updates prerequisites and the sample .csproj TFM to .NET 10. |
docs/specs/022-packaging-and-distribution.md |
Updates packaging/distribution spec snippets to .NET 10 TFMs and runtime references. |
docs/specs/030-reactor-gallery-design.md |
Updates example project TFM to .NET 10. |
docs/specs/035-demo-script-tool-design.md |
Updates the demo prompt to reference .NET 10. |
tests/startup_perf/diag.ps1 |
Updates $tfm to the net10 output folder name. |
tests/stress_perf/SPEC.md |
Updates stress perf harness TFM references to .NET 10. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 9/9 changed files
- Comments generated: 1
Address Copilot CR on #245: line 457 referenced `lib/net10.0-windows10.0.22621/` which dropped the trailing `.0`, inconsistent with the canonical layout in the same spec (`lib/net10.0-windows10.0.22621.0/`). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Addressed Copilot CR comment on line 457: fixed in ba545b4 — restored the trailing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net10.0everywhere (every.csproj,global.jsonSDK10.0.100, CIdotnet-version: 10.0.x), but several setup docs, design specs, and one bench script still pointed at.NET 8/.NET 9— confusing for new contributors trying to set up.README.md,CONTRIBUTING.md,AGENTS.md,selfhost-facing spec snippets, andtests/startup_perf/diag.ps1so every reference matches the actual build.Directory.Build.targetsfromnet8.0tonet10.0. Semantically identical for the current project set (all projects are eithernet10.0*ornetstandard2.0), but the baseline now reflects reality.Files touched:
AGENTS.md,CONTRIBUTING.md,Directory.Build.targets,README.md,docs/specs/022-packaging-and-distribution.md,docs/specs/030-reactor-gallery-design.md,docs/specs/035-demo-script-tool-design.md,tests/startup_perf/diag.ps1,tests/stress_perf/SPEC.md.Intentionally left untouched:
tools/reviewer/skills/cs-*.md(generic C# review knowledge base;net8.0appears in illustrative examples, not Reactor's target), historical fix reports / perf baselines, andselfhost/mur.deps.json(a build artifact that regenerates).Test plan
dotnet restore Reactor.slnx— cleandotnet build Reactor.slnx --no-restore --no-incremental -c Release— 0 errors, 24 pre-existing warnings (NU1903, sample-only A11Y analyzers,ReactorApp.ActiveHostobsolete usage in samples)dotnet test tests/Reactor.Tests -p:Platform=ARM64 -c Release— 6951 passed, 46 skipped, 0 faileddotnet test tests/Reactor.SelfTests -c Release— 671 passed, 0 failed🤖 Generated with Claude Code